Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Edge] Update docs for Datastream config override feature #427

Merged
merged 23 commits into from
Oct 30, 2023
Merged

[Edge] Update docs for Datastream config override feature #427

merged 23 commits into from
Oct 30, 2023

Conversation

addb
Copy link
Contributor

@addb addb commented Oct 12, 2023 •
edited
Loading

Description

Screenshot 2023-10-25 at 11 26 04 AM

Datastream config override for Edge events using Rules_.pdf

PDF to show the UI for the Doc:

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@addb addb requested review from calebk1 and stcheng-adobe October 12, 2023 20:03
@addb addb mentioned this pull request Oct 16, 2023
Closed
emdobrin
emdobrin reviewed Oct 24, 2023
View reviewed changes
src/pages/edge/edge-network/tabs/api-reference.md Outdated Show resolved Hide resolved
src/pages/edge/edge-network/tabs/api-reference.md Show resolved Hide resolved
src/pages/edge/edge-network/tabs/api-reference.md Show resolved Hide resolved
src/pages/edge/edge-network/tabs/api-reference.md Outdated Show resolved Hide resolved
src/pages/edge/edge-network/tabs/api-reference.md Outdated Show resolved Hide resolved
gatsby-config.js Outdated Show resolved Hide resolved
src/pages/edge/edge-network/datastream-config-override-using-tags.md Outdated Show resolved Hide resolved
src/pages/edge/edge-network/datastream-config-override-using-tags.md Outdated Show resolved Hide resolved
src/pages/edge/edge-network/datastream-config-override-using-tags.md Outdated Show resolved Hide resolved
src/pages/edge/edge-network/datastream-config-override-using-tags.md Outdated Show resolved Hide resolved
@addb addb requested review from emdobrin October 25, 2023 18:30
emdobrin
emdobrin reviewed Oct 27, 2023
View reviewed changes
src/pages/edge/edge-network/tutorials/datastream-config-override-rules.md Outdated Show resolved Hide resolved
src/pages/edge/edge-network/tabs/api-reference.md Outdated Show resolved Hide resolved
src/pages/edge/edge-network/assets/configOverrides/add-xdm-event-type.png Outdated Show resolved Hide resolved
src/pages/edge/edge-network/api-reference.md Outdated Show resolved Hide resolved
src/pages/edge/edge-network/tutorials/datastream-config-override-rules.md Outdated Show resolved Hide resolved
src/pages/edge/edge-network/tutorials/datastream-config-override-rules.md Outdated Show resolved Hide resolved
src/pages/edge/edge-network/tutorials/datastream-config-override-rules.md Outdated Show resolved Hide resolved
src/pages/edge/edge-network/tutorials/datastream-config-override-rules.md Outdated Show resolved Hide resolved
@addb addb changed the title [Do Not Merge] Update docs for Datastream config override feature Update docs for Datastream config override feature Oct 27, 2023
@addb addb changed the title Update docs for Datastream config override feature [Edge] Update docs for Datastream config override feature Oct 27, 2023
emdobrin
emdobrin approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@emdobrin emdobrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with couple open questions, thanks @addb ! ✌️

calebk1
calebk1 reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@calebk1 calebk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments!

src/pages/edge/edge-network/tutorials/datastream-config-override-rules.md Outdated Show resolved Hide resolved
src/pages/edge/edge-network/tutorials/datastream-config-override-rules.md Outdated Show resolved Hide resolved
src/pages/edge/edge-network/tutorials/datastream-config-override-rules.md Outdated Show resolved Hide resolved
src/pages/edge/edge-network/tutorials/datastream-config-override-rules.md Outdated Show resolved Hide resolved
src/pages/edge/edge-network/tutorials/datastream-config-override-rules.md Outdated Show resolved Hide resolved
@addb addb requested a review from calebk1 October 27, 2023 21:21
@emdobrin emdobrin merged commit 41eb3b6 into AdobeDocs:main Oct 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emdobrin emdobrin emdobrin approved these changes

@stcheng-adobe stcheng-adobe Awaiting requested review from stcheng-adobe

@calebk1 calebk1 Awaiting requested review from calebk1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addb @emdobrin @calebk1